Skip to content

[18.06] backport bash completion for service create|update --init #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
albers merged 1 commit into from
Jul 13, 2018
Merged

[18.06] backport bash completion for service create|update --init #1211

albers merged 1 commit into from
Jul 13, 2018

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 13, 2018

cherry-pick of #1210 for 18.06

cherry-pick was clean; no conflicts

This adds bash completion for #479.

@albers @thaJeztah
Add bash completion for service create|update --init
a92b4dc 
Signed-off-by: Harald Albers <[email protected]>
(cherry picked from commit 97d312e)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 18.06.0 milestone Jul 13, 2018
@thaJeztah thaJeztah requested a review from albers as a code owner July 13, 2018 09:06
@thaJeztah
Copy link
Member Author

thaJeztah commented Jul 13, 2018

/cc @albers @vdemeester

vdemeester
vdemeester approved these changes Jul 13, 2018
View reviewed changes
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

albers
albers approved these changes Jul 13, 2018
View reviewed changes
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albers albers merged commit 9cb345c into docker:18.06 Jul 13, 2018
@thaJeztah thaJeztah deleted the 18.06-backport-completion-service-create--init branch July 13, 2018 14:18
@thaJeztah thaJeztah changed the title [18.06] Add bash completion for service create|update --init [18.06] backport bash completion for service create|update --init Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@albers albers albers approved these changes

Assignees

No one assigned

Labels

area/completion status/2-code-review

Projects

None yet

Milestone

18.06.0

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @vdemeester @albers @GordonTheTurtle